Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executors/bf: suppress instcombine error for llvm >=18 #1193

Merged
merged 1 commit into from
Dec 21, 2024
Merged

executors/bf: suppress instcombine error for llvm >=18 #1193

merged 1 commit into from
Dec 21, 2024

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Dec 21, 2024 •
edited
Loading

bf is broken due to

dmoj.error.CompileError: LLVM ERROR: Instruction Combining did not reach a fixpoint after 1 iterations

use the instcombine<no-verify-fixpoint> trick from llvm/llvm-project#92648 to suppress this error

0.929 Testing BF:     Success                                                                                                                                                                              
1.201   opt: 19.1.6                                                                                                                                                                                        
1.214   llc: 19.1.6                                                                                                                                                                                        
1.214   ld_x64: 2.43.50.20241215
1.214 
1.214 Configuration result:
1.214 runtime:
1.214   ld_x64: /usr/bin/x86_64-linux-gnu-ld
1.214   llc: /usr/bin/llc
1.214   opt: /usr/bin/opt

unfortunately, 'instcombine<no-verify-fixpoint>' doesn't exist in llvm 16, and this is causing ci to fail

for llvm 17 and earlier, use instcombine. for llvm 18 and later, use instcombine<no-verify-fixpoint>.

@dmoj-build
Copy link
Collaborator

Can one of the admins verify this patch?

quantum5
quantum5 reviewed Dec 21, 2024
View reviewed changes
dmoj/executors/BF.py Outdated Show resolved Hide resolved
@int-y1 int-y1 changed the title executors/bf: suppress llvm instcombine error executors/bf: suppress instcombine error for llvm >=18 Dec 21, 2024
@quantum5
Copy link
Member

ok to test

@quantum5
Copy link
Member

rerun freebsd ci

1 similar comment
@quantum5
Copy link
Member

rerun freebsd ci

@quantum5 quantum5 merged commit 7701313 into DMOJ:master Dec 21, 2024
9 of 10 checks passed
@int-y1 int-y1 deleted the fix-bf branch December 21, 2024 20:45
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (f9e3356) to head (fdf061c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dmoj/executors/BF.py 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1193       +/-   ##
===========================================
+ Coverage   49.37%   62.14%   +12.77%     
===========================================
  Files         143      143               
  Lines        5430     5442       +12     
===========================================
+ Hits         2681     3382      +701     
+ Misses       2749     2060      -689
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantum5 quantum5 quantum5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@int-y1 @dmoj-build @quantum5